Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vuetify #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update Vuetify #9

wants to merge 5 commits into from

Conversation

KaelWD
Copy link

@KaelWD KaelWD commented Sep 26, 2023

No description provided.

@KaelWD
Copy link
Author

KaelWD commented Sep 26, 2023

@KaelWD
Copy link
Author

KaelWD commented Sep 26, 2023

Not clear what the difference between "select button" and "toggle button" is but we have https://vuetifyjs.com/en/components/button-groups/

@ddahan
Copy link
Owner

ddahan commented Sep 26, 2023

Hi :)

Does "not importing any styles" count as unstyled?

In my mind, a library is "unstyled" if it has been thought from the ground up to let the styling up to the user.
Note that a library can be both if both modes are thought. This is the case for PrimeVue.
I don't know Vuetify very well so I let you judge :)

Not clear what the difference between "select button" and "toggle button" is

If my memory serves me right, it mirrors https://primevue.org/selectbutton/ and https://primevue.org/togglebutton/

Copy link
Owner

@ddahan ddahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask to add a link to every add? This is really helpful for review (and because sometimes it's not an omission, it's on purpose, so it helps to understand where the add come from). Thanks.

@KaelWD
Copy link
Author

KaelWD commented Sep 29, 2023

I've added links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants