♻️ Properly propagate --no-cache-dir #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelange
force-pushed
the
no-cache-dir
branch
from
54bbc50
to
ce9f954
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
==========================================
- Coverage 78.29% 78.11% -0.18%
==========================================
Files 29 29
Lines 2824 2829 +5
Branches 793 792 -1
==========================================
- Hits 2211 2210 -1
- Misses 442 445 +3
- Partials 171 174 +3
☔ View full report in Codecov by Sentry. |
ddelange
force-pushed
the
no-cache-dir
branch
from
a2f0107
to
041e5a1
Compare
|
Released 0.10.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--cache-dirand--no-cache-dir, would leave all wheels duplicated inos.path.join(USER_CACHE_DIR, "wheels", "pipgrip")--cache-dir, would additionally leave all wheels duplicated in the defaultUSER_CACHE_DIR(by pip behaviour, was propagating pipgrip --cache-dir value as pip --wheel-dir value in thepip wheelcommand, leaving --cache-dir to the default)--no-cache-dir, would leave all wheel duplicated in the defaultUSER_CACHE_DIR, as it just set pipgrip--cache-dirvalue to a temp dir, which then went intopip wheel --wheel-dir, leaving pip--cache-dirto the default (same as bullet point above)