Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙈 git-ignore common Python development files #125

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

kurtmckee
Copy link
Contributor

This addresses a significant number of unignored files generated by running pytest locally.

So far, I've been unable to run pipgrip on Windows (it crashes for multiple reasons), so I'm working to resolve an existing test suite failure before attempting to resolve the crashes I'm seeing.

This addresses a significant number of files generated
by running pytest locally.
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb886c2) 78.36% compared to head (0ce6a2e) 78.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files          29       29           
  Lines        2829     2829           
  Branches      794      794           
=======================================
  Hits         2217     2217           
  Misses        443      443           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kurtmckee
Copy link
Contributor Author

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Calling out that this notification appears in all Codecov messages.

@ddelange
Copy link
Owner

ddelange commented Nov 12, 2023

Hey @kurtmckee 👋

I'll close this one in favour of a user-wide ~/.gitignore:

curl -sLw "\n" "http://gitignore.io/api/macos,python,django,sublimetext" >> ~/.gitignore
git config --global core.excludesfile "~/.gitignore"

For all possibilities, see http://gitignore.io/api/list.

That should cover each developer's personal favourite editor / python setup / dev environment and they can forget about it forever!

@ddelange ddelange closed this Nov 12, 2023
@ddelange
Copy link
Owner

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Calling out that this notification appears in all Codecov messages.

Thanks, fixed!

@ddelange
Copy link
Owner

added git config --global core.excludesfile "~/.gitignore" in the comment above

@kurtmckee kurtmckee deleted the update-gitignore branch November 12, 2023 16:14
@kurtmckee kurtmckee restored the update-gitignore branch November 12, 2023 16:14
@kurtmckee
Copy link
Contributor Author

kurtmckee commented Nov 12, 2023

I use a global gitignore for both Linux and Windows to cover my own editor files and virtual environment directories and so forth, but I recommend including language-specific ignores in-repo so that junior developers can contribute with fewer difficulties.

I hope you'll reconsider including these Python language- and tool-specific ignores.

@ddelange
Copy link
Owner

fair enough! your argument outweighs the sake of deduplication :)

@ddelange ddelange reopened this Nov 12, 2023
@ddelange ddelange changed the title git-ignore common Python development files 🙈 git-ignore common Python development files Nov 12, 2023
@ddelange ddelange merged commit 7f5692e into ddelange:master Nov 12, 2023
13 checks passed
@kurtmckee
Copy link
Contributor Author

Thank you for reconsidering! 🙏👍

@kurtmckee kurtmckee deleted the update-gitignore branch November 12, 2023 16:58
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants