Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verbose instructions for Solr 7 and Drupal 7, fixes #44 #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenlampton
Copy link

@jenlampton jenlampton commented Dec 13, 2024

The Issue

README only includes docs for Drupal 9+

How This PR Solves The Issue

Adds legacy instructions for Drupal 7

Manual Testing Instructions

N/A

Automated Testing Overview

N/A

Related Issue Link(s)

#44 (comment)

Release/Deployment Notes

Does this affect anything else or have ramifications for other code? Does anything have to be done on deployment?

Nope :)

@rfay rfay changed the title Added verbose instructions for Solr 7 and Drupal 7 Added verbose instructions for Solr 7 and Drupal 7, fixes #44 Dec 13, 2024
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for developing your expertise on this and contributing it back. I'm sorry I'm slow to respond, was hoping for another review, but this will be super helpful to people with just a little adjustment, mostly using docker-compose.solr_extras.yaml instead of editing the original file.

### Ddev / Solr configuration

1. Install this add-on: `ddev add-on get ddev/ddev-drupal-solr`
2. Set the version of Solr verison 7: Edit the `.ddev/docker-compose.solr.yaml` file. Replace `image: solr:8` with `image: solr:7` on line 34.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Set the version of Solr verison 7: Edit the `.ddev/docker-compose.solr.yaml` file. Replace `image: solr:8` with `image: solr:7` on line 34.
2. Set the version of Solr version 7: Edit the `.ddev/docker-compose.solr.yaml` file. Replace `image: solr:8` with `image: solr:7` on line 34.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than editing the .ddev/docker-compose-solr.yaml it's best practice to use a .ddev/docker-compose-solr_extras.yaml to override the value (in your case, it would seem to need only:

services:
  solr:
     image: solr: 7

That way a ddev add-on get won't overwrite your work. Also, if you did edit the way you say here, the docker-compose.solr.yaml would have to have the #ddev-generated line removed from it, or it would be overwritten.

3. Add the schema needed for version 7: Defaults can be found in the Search API Solr in the `search_api_solr/solr-conf/7.x` directory . Copy these files into `.ddev/solr/conf`.
4. Restart Ddev: `ddev restart`.
5. Confirm Solr is working by visiting `http://<projectname>.ddev.site:8983/solr/`.
6. If the Ddev drush version is too new for Drupal 7, you may need to symlink `drush` to the `drush8` provided with Ddev. You can do this by adding a `post-start` hook inside your `.ddev/config.yaml` file as follows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this. If a project is configured with project type drupal7 (or backdrop I think) then drush is already drush8, so why would one need to do this? Using project type php ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants