Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight support patterns #137

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Highlight support patterns #137

merged 2 commits into from
Nov 8, 2023

Conversation

tyler36
Copy link
Contributor

@tyler36 tyler36 commented Nov 8, 2023

This PR adds links to each support pattern on the contributing page.

  • highlights at glance some methods
  • enables links that can be shared

rfay
rfay reviewed Nov 8, 2023
View reviewed changes
src/pages/support-ddev.astro Outdated Show resolved Hide resolved
@tyler36 tyler36 requested a review from rfay November 8, 2023 01:25
mattstein
mattstein approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mattstein mattstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I’d use hyphens for word separators to be consistent, but that’s mostly nitpicky preference.

@tyler36
Copy link
Contributor Author

tyler36 commented Nov 8, 2023

I’d use hyphens for word separators to be consistent, but that’s mostly nitpicky preference.

Updated.

@tyler36 tyler36 requested a review from mattstein November 8, 2023 02:16
rfay
rfay approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfay rfay merged commit 4089100 into ddev:main Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattstein mattstein mattstein approved these changes

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tyler36 @rfay @mattstein