Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbl_cross and add_p.tbl_cross unit tests #1836

Merged
merged 9 commits into from
Jul 20, 2024
Merged

tbl_cross and add_p.tbl_cross unit tests #1836

merged 9 commits into from
Jul 20, 2024

Conversation

Melkiades
Copy link
Collaborator

@Melkiades Melkiades commented Jul 12, 2024

What changes are proposed in this pull request?
Adding unit tests to tbl_cross and add_p.tbl_cross

If there is an GitHub issue associated with this pull request, please provide link.


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: renv::install()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@Melkiades Melkiades added the v2.0 label Jul 12, 2024
@Melkiades Melkiades marked this pull request as draft July 12, 2024 15:44
@Melkiades Melkiades marked this pull request as ready for review July 13, 2024 09:17
@Melkiades Melkiades added this to the v2.0.0 milestone Jul 15, 2024
@Melkiades Melkiades added v2.0 🤞🤞 A nice-to-have for the v2.0 release and removed v2.0 labels Jul 15, 2024
@ddsjoberg
Copy link
Owner

@Melkiades is this ready for review? thanks!

Copy link
Owner

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Melkiades !!

@ddsjoberg ddsjoberg merged commit 995c1fe into main Jul 20, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the tbl_cross_uat@main branch July 20, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.0 🤞🤞 A nice-to-have for the v2.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants