-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translations: fix copyright notices #1113
Open
amezin
wants to merge
1
commit into
master
Choose a base branch
from
translations-copyright
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER placeholder with Copyright (C) YEAR ddterm contributors Add the header where it's missing. .pot file will be fixed automatically by CI.
amezin
requested review from
xmkg,
DasJott,
vantu5z,
comradekingu,
yuhldr,
daPhipz,
frankie-mceyes,
arnaud-feldmann,
DuckyCB and
novak-pavel
November 24, 2024 23:02
xmkg
approved these changes
Nov 25, 2024
I approve to these copyright changes. |
arnaud-feldmann
approved these changes
Nov 25, 2024
daPhipz
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine with me 👍🏼
vantu5z
approved these changes
Nov 25, 2024
DuckyCB
approved these changes
Nov 25, 2024
yuhldr
approved these changes
Dec 2, 2024
Good for me too 👍🏻 |
frankie-mceyes
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, translation files either contain a placeholder:
or no explicit copyright notice at all. I'm trying to make the repository compliant with https://reuse.software/ - it requires explicit per-file copyright notices everywhere.
This PR replaces the placeholder with
And adds the notice where it's missing. .pot file will be fixed automatically by CI.
On one hand, this doesn't change the license, and all possible copyright holders are still included. On the other hand, to be completely safe I should likely ask all contributors for permission - but it's not feasible, some people just don't respond. So I decided to ask at least those who joined the organization.