Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pin-project with pin-project-lite #19

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

ravenclaw900
Copy link
Contributor

@ravenclaw900 ravenclaw900 commented Jul 27, 2023

pin-project-lite is a version of pin-project written with declarative macros instead of proc macros. It has the same feature set, but removes all proc macro related dependencies. It is used by tokio and hyper as an alternative to pin-project.

After reading #3, I saw that pin-project-lite was offered as an option there, but not used. I think that since both hyper and tokio now use pin-project-lite, it should be safe to switch over, and it will clean up the dependency tree for projects using this crate.

@de-vri-es
Copy link
Owner

Oops, I somehow missed that you made a PR for it instead of an issue. Let me do some fiddling with git to get your commit in the main branch.

@de-vri-es de-vri-es merged commit 931f2e9 into de-vri-es:main Jul 31, 2023
1 check passed
@de-vri-es
Copy link
Owner

Merged and release as v0.11.1 (although not in that order 😄 )

tungstenite still pulls in thiserror which pulls in proc-macro crates, but atleast we're not pulling them in here anymore!

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants