Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: upgrade deps, node 20, actions #27

Merged
merged 1 commit into from
Jan 24, 2024
Merged

major: upgrade deps, node 20, actions #27

merged 1 commit into from
Jan 24, 2024

Conversation

smlgbl
Copy link
Contributor

@smlgbl smlgbl commented Jan 24, 2024

No description provided.

@de-vri-es
Copy link
Owner

de-vri-es commented Jan 24, 2024

Looks good. Thanks!

I think we can release this with only a minor version bump though. The public behaviour of the action didn't change. Or did I miss something?

@de-vri-es de-vri-es merged commit a018e7f into de-vri-es:main Jan 24, 2024
9 checks passed
@smlgbl
Copy link
Contributor Author

smlgbl commented Jan 24, 2024

No, you are right. No behaviour changes.

@de-vri-es
Copy link
Owner

Okay. Released as v2.1.0.

Thanks for the PR! 🥳

@smlgbl
Copy link
Contributor Author

smlgbl commented Jan 30, 2024

Thanks for merging, but you did not create a release. Any reason?

@de-vri-es
Copy link
Owner

I tagged v2.1.0, v2.1 and v2. Note that I had to downgrade to node16. See #28.

@de-vri-es
Copy link
Owner

Ah, I forgot about the github release thingy. Made the new releases now too.

@de-vri-es
Copy link
Owner

From the docs, I agree that node20 should be fine. Lets see what we find out at #28. In the mean time the downgrade is the safe option.

But if it's an outdated custom runner, then I think we can just add a note to the README to use v2.0 for those cases, and upgrade to node20 again.

@de-vri-es
Copy link
Owner

Alright, upgraded and released again :p

Thanks again for doing the maintenance!

@michaelmcguire
Copy link

Was there a reason that the node_modules got included in the repo with this update?

@de-vri-es
Copy link
Owner

de-vri-es commented Feb 12, 2024

Yes, the javascript code is required for workflows using the action. They don't run the typescript compiler first.

(It was already included before too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants