Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix illumos build after f224d37e0737d #21

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

jclulow
Copy link
Contributor

@jclulow jclulow commented Nov 15, 2023

I believe a refactoring was not taken into account on illumos systems. I have taken a naive swing at fixing it, and the tests at least now pass for me:

 $ cargo test
    Finished test [unoptimized + debuginfo] target(s) in 0.04s
     Running unittests src/lib.rs (target/debug/deps/tokio_seqpacket-3625990b5fb4a608)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/ancillary_fds.rs (target/debug/deps/ancillary_fds-c7be225741801dfc)

running 2 tests
test can_take_ownership_of_received_fds ... ok
test pass_fd ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/ancillary_fds_dropped.rs (target/debug/deps/ancillary_fds_dropped-2c9a4b92608e5db6)

running 1 test
test dropping_ancilarry_drops_owned_fds ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/listener.rs (target/debug/deps/listener-d7a09ca59faf9931)

running 1 test
test unix_seqpacket_listener ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/multiple_fds.rs (target/debug/deps/multiple_fds-0b968867376a9329)

running 1 test
test can_take_ownership_of_received_fds ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/raw_fd.rs (target/debug/deps/raw_fd-f374795d097e712c)

running 1 test
test send_recv ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/socket.rs (target/debug/deps/socket-2b0b4f8ef438307e)

running 5 tests
test send_recv ... ok
test send_recv_vectored ... ok
test send_recv_out_of_order ... ok
test multiple_waiters ... ok
test echo_loop ... ok

test result: ok. 5 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.06s

     Running tests/split.rs (target/debug/deps/split-d25bd6a9856822fd)

running 1 test
test send_recv ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests tokio-seqpacket

running 7 tests
test src/ancillary/writer.rs - ancillary::writer::AncillaryMessageWriter<'a>::new (line 47) - compile ... ok
test src/lib.rs - (line 29) - compile ... ok
test src/ancillary/writer.rs - ancillary::writer::AncillaryMessageWriter<'a>::add_fds (line 81) - compile ... ok
test src/ancillary/reader.rs - ancillary::reader::AncillaryMessageReader<'a>::is_truncated (line 143) - compile ... ok
test src/ancillary/writer.rs - ancillary::writer::AncillaryMessageWriter (line 10) - compile ... ok
test src/ancillary/reader.rs - ancillary::reader::AncillaryMessageReader (line 8) - compile ... ok
test src/socket.rs - socket::UnixSeqpacket::as_async_fd (line 116) ... ok

test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.41s

This is on relatively recent OS bits:

$ uname -a
SunOS vulcan 5.11 helios-2.0.22112 i86pc i386 i86pc

@de-vri-es
Copy link
Owner

Thanks! Yeah, I must have forgotten to atleast run cargo check for illumos :(

The test failure does not seem related to your PR.

@de-vri-es de-vri-es self-assigned this Nov 15, 2023
@de-vri-es
Copy link
Owner

I will merge this after I fixed the tests!

@jclulow
Copy link
Contributor Author

jclulow commented Nov 15, 2023

Thank you!

@de-vri-es de-vri-es merged commit 4ef900f into de-vri-es:main Nov 15, 2023
4 of 5 checks passed
@de-vri-es
Copy link
Owner

de-vri-es commented Nov 15, 2023

Released as 0.7.1! 🥳

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants