Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apps): add search bar & misc #291

Merged
merged 6 commits into from
Oct 9, 2024
Merged

feat(apps): add search bar & misc #291

merged 6 commits into from
Oct 9, 2024

Conversation

kyrie25
Copy link
Contributor

@kyrie25 kyrie25 commented Oct 7, 2024

  • Adds search bar to App Detection RPC (More Translation & Feature Suggestions #279)
  • Fix spamming "No updates available" (More Translation & Feature Suggestions #279)
  • Set Media/Experimental RPC activity state and type on initial start (no buffer time waiting from Playing to selected activity type)
  • Features will be auto switched off if another feature is turned on to avoid confusion
  • Fix clipping title bar text when collapsed
    image
  • Drawer card layout updates
    image
  • Minor changes to original strings
  • Proofread vi strings

@kyrie25 kyrie25 marked this pull request as draft October 8, 2024 03:33
@kyrie25
Copy link
Contributor Author

kyrie25 commented Oct 8, 2024

Everything still works, I just need to customize some stylings to make it fit the overall layout of the app

@dead8309
Copy link
Owner

dead8309 commented Oct 8, 2024

Also you can use Searchbar component from common module

@kyrie25
Copy link
Contributor Author

kyrie25 commented Oct 8, 2024

Also you can use Searchbar component from common module

I didn't know that existed tbh :p
Sure thing, gonna look into it!

@kyrie25 kyrie25 marked this pull request as ready for review October 8, 2024 11:38
@kyrie25 kyrie25 requested a review from dead8309 October 8, 2024 11:39
dead8309
dead8309 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Owner

@dead8309 dead8309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good, will merge tomorrow after testing locally

@dead8309 dead8309 merged commit 52eea50 into dead8309:master Oct 9, 2024
1 check passed
@kyrie25 kyrie25 deleted the search-bar-app-rpc branch October 9, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead8309 dead8309 dead8309 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyrie25 @dead8309