Adding custom application id feature #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead8309
reviewed
Oct 29, 2024
feature_settings/src/main/java/com/my/kizzy/feature_settings/rpc_settings/RpcSettings.kt
Outdated
Show resolved
Hide resolved
dead8309
reviewed
Oct 29, 2024
feature_settings/src/main/java/com/my/kizzy/feature_settings/rpc_settings/RpcSettings.kt
Outdated
Show resolved
Hide resolved
…ture' into adding-Custom-Application-ID-Feature
dead8309
reviewed
Oct 30, 2024
feature_settings/src/main/java/com/my/kizzy/feature_settings/rpc_settings/RpcSettings.kt
Outdated
Show resolved
Hide resolved
dead8309
reviewed
Oct 30, 2024
feature_settings/src/main/java/com/my/kizzy/feature_settings/rpc_settings/RpcSettings.kt
Outdated
Show resolved
Hide resolved
dead8309
reviewed
Oct 30, 2024
|
Closes: #280 |
|
Can you check what the conflicts are before merging @dead8309? |
yeah i got you |
dead8309
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review code for implementing a custom application ID field. The main logic should be in place now, although the strings haven't been translated to the different languages, and there were a few other places where Constants.APPLICATION_ID was used (namely the ImgurApiService and the GetCurrentPlayingMedia files), which I'm not sure about.