Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home): add connection status banner #327

Closed
wants to merge 1 commit into from

Conversation

kyrie25
Copy link
Contributor

@kyrie25 kyrie25 commented Oct 30, 2024

As mentioned in #279

image
image
image

@dead8309
Copy link
Owner

dead8309 commented Oct 30, 2024

You don't need to call endpoints to check if network is present a simple NetworkMonitor class which gives out a flow of Boolean values is enough. See

Also the view should be above topbar.
I'll implement it later but thanks for raising a pr for it.

@dead8309 dead8309 closed this Oct 30, 2024
@kyrie25
Copy link
Contributor Author

kyrie25 commented Oct 30, 2024

You don't need to call endpoints to check if network is present a simple NetworkMonitor class which gives out a flow of Boolean values is enough. See

Either Workers being down or Discord being ISP-blocked can result in Kizzy not being able to work, hence the HEAD requests. This is the case for a significant number of users and would help understand why Kizzy isn't working.

Else simply stating if user has Internet connection or not would be as helpful as looking at their status bar and doesn't reflect the working state of the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants