Add distributed moving laser heating #92
Conversation
change dependency
add figures in readme
correct images
Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc
Outdated
Show resolved
Hide resolved
Distributed_Moving_Laser_Heating/Distributed_Moving_Laser_Heating.cc
Outdated
Show resolved
Hide resolved
| // this library is deprecated. use affine_constraints.h instead | ||
| //#include <deal.II/lac/constraint_matrix.h> |
There was a problem hiding this comment.
| // this library is deprecated. use affine_constraints.h instead | |
| //#include <deal.II/lac/constraint_matrix.h> |
| // this library is deprecated. use affine_constraints.h instead | |
| //#include <deal.II/lac/constraint_matrix.h> | |
| // this library is deprecated. use affine_constraints.h instead | |
| //#include <deal.II/lac/constraint_matrix.h> |
| #ifndef GLOBAL_PARA | ||
| #define GLOBAL_PARA | ||
| #include "./globalPara.h" | ||
| #include "./boundaryInit.h" | ||
| #include "./rightHandSide.h" | ||
| #endif |
| #ifndef GLOBAL_PARA | ||
| #define GLOBAL_PARA | ||
| #include "./globalPara.h" | ||
| #include "./boundaryInit.h" | ||
| #include "./rightHandSide.h" | ||
| #endif |
| @@ -0,0 +1 @@ | |||
| Laplace equation surface coupled to an external simulation program (here simply a fancy boundary condition) using the coupling library preCICE. | |||
| where $n$ is the time step number, and $dt$ is the time step. | ||
|
|
||
| <h3> The initial condition </h3> | ||
| Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial, |
There was a problem hiding this comment.
| Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial, | |
| deall.II provides an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial, |
| Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial, | |
| Deall.II has provide an interpolation function (VectorTools::interpolate) to distribute initial conditions. However, in this tutorial, |
|
|
||
|  | ||
|
|
||
| ## numerical results |
There was a problem hiding this comment.
| ## numerical results | |
| ## Numerical results |
| ## numerical results | |
| ## numerical results |
|
@MarkMa1990 I will second @peterrum 's observation that we let this sit around for too long without giving you feedback :-( @peterrum left a number of comments on this program. Do you think you have the time to address them and upload a new version? I will then look at it as well! |
|
yes, I will do it this weekend. thanks for the reply
Wolfgang Bangerth ***@***.***> 于2022年7月18日周一 23:38写道：
… @MarkMa1990 <https://github.com/MarkMa1990> I will second @peterrum
<https://github.com/peterrum> 's observation that we let this sit around
for too long without giving you feedback :-(
@peterrum <https://github.com/peterrum> left a number of comments on this
program. Do you think you have the time to address them and upload a new
version? I will then look at it as well!
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACRNXAWWMEQQQPYMIULGU4LVUXFFZANCNFSM5JHVTTLA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Excellent, we look forward to it! |
Co-authored-by: Peter Munch <[email protected]>
Co-authored-by: Peter Munch <[email protected]>
delete the commented petsc part
…ing.cc accepted Co-authored-by: Peter Munch <[email protected]>
…ing.cc Co-authored-by: Peter Munch <[email protected]>
…ing.cc Co-authored-by: Peter Munch <[email protected]>
|
Oh, did we never notice that you updated all of the things that @peterrum had commented on? In other words, is this ready to be merged from your side? |
|
My apologies that none of us saw that! In the future, add a comment whenever you address comments and we know that we should take another look. |
There was a problem hiding this comment.
I've made a few changes so that your program compiles and runs with the latest deal.II 9.4.0 release.
I have one question: What is the purpose of the docs_old folder? If it doesn't serve any purpose, I would vote to delete it. There is documentation in that folder though, i.e. intro.dox and results.dox, that we should save and move to docs.
Otherwise I would say that after @peterrum's extensive review this is ready to merge.
marcfehling
force-pushed
the
master
branch
3 times, most recently
from
549fe5e to
7aef0d6
Compare
|
I did another force push to make sure that this code compiles on the new CI workflow introduced in #142. |
| /* | ||
| #include <deal.II/lac/petsc_parallel_vector.h> | ||
| #include <deal.II/lac/petsc_parallel_sparse_matrix.h> | ||
| #include <deal.II/lac/petsc_solver.h> | ||
| #include <deal.II/lac/petsc_precondition.h> | ||
| */ |
This program aims to solve the non-uniform isotropic heat equation with distributed memory.
as suggested by wolfgang, the program is moved here.
dealii/dealii#13023 (comment)