Retry more Google API failures.

[jpd236]

The default retry policy (documented
here) does not retry POST requests. But most Google API calls use POST requests under the covers, including read-only APIs like Drive
Activity. So we can also ask to retry POST requests.

We retain other aspects of the default policy, such as the number of attempts (3) and the HTTP status codes to retry (100-109, 408, 429, 5xx). If a request succeeds on a retry, the failure is kept silent and does not pollute the logs.

The main risk is that a POST method might mutate some state despite returning a failure, and that inline retries might handle that incorrectly or otherwise make things worse than retrying the full flow from the ground up. This doesn't seem likely to be an issue with the current set of API calls, but if desired, we could narrow this change to specific known-safe requests.

See #2160
See #2161

[ebroder]

LGTM

Noting just for the record that we may end up needing to add some error handling logic around stuff like Drive permissions, where the APIs may not be idempotent but a "resource already exists" error shouldn't cause us to blow up. But this seems strictly better than that case

[ebroder]

Not sure why builds aren't running on this commit. Maybe amend and re-push and see if it kicks off?

[jpd236]

Thanks!

Noting just for the record that we may end up needing to add some error handling logic around stuff like Drive permissions, where the APIs may not be idempotent but a "resource already exists" error shouldn't cause us to blow up. But this seems strictly better than that case

Yep, definitely possible there'll be more to do here. FWIW, I did try API Explorer with the Drive permissions.create API, and it seems to be idempotent in that repeated calls return 200 with the same Permission object. So this does feel like it should be enough to help with #2160 (and #2161, which is readonly).

Not sure why builds aren't triggering here, but on my fork I'm seeing an error:

Error: imports/server/googleClientRefresher.ts(111,7): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Type 'import("/home/runner/work/jolly-roger/jolly-roger/node_modules/gaxios/build/src/common").RetryConfig' is not assignable to type 'import("/home/runner/work/jolly-roger/jolly-roger/node_modules/googleapis-common/node_modules/gaxios/build/src/common").RetryConfig'.
      Types of property 'onRetryAttempt' are incompatible.
        Type '((err: import("/home/runner/work/jolly-roger/jolly-roger/node_modules/gaxios/build/src/common").GaxiosError<any>) => void | Promise<void>) | undefined' is not assignable to type '((err: import("/home/runner/work/jolly-roger/jolly-roger/node_modules/googleapis-common/node_modules/gaxios/build/src/common").GaxiosError<any>) => void | Promise<void>) | undefined'.
          Type '(err: import("/home/runner/work/jolly-roger/jolly-roger/node_modules/gaxios/build/src/common").GaxiosError<any>) => void | Promise<void>' is not assignable to type '(err: import("/home/runner/work/jolly-roger/jolly-roger/node_modules/googleapis-common/node_modules/gaxios/build/src/common").GaxiosError<any>) => void | Promise<void>'.
            Types of parameters 'err' and 'err' are incompatible.
              Property '[GAXIOS_ERROR_SYMBOL]' is missing in type 'import("/home/runner/work/jolly-roger/jolly-roger/node_modules/googleapis-common/node_modules/gaxios/build/src/common").GaxiosError<any>' but required in type 'import("/home/runner/work/jolly-roger/jolly-roger/node_modules/gaxios/build/src/common").GaxiosError<any>'.

googleapis-common has a conflicting dependency on an older version of gaxios but I'm not immediately sure how to resolve it. Locally it seems like reinstalling googleapis-common fixed it, but the server build is failing even after I blew away the cache... Need to dig further, but let me know if you have any ideas.

[jpd236]

Fixed the dependency conflict by running npm dedupe. That resulted in many unrelated changes to package-lock.json. Hopefully that's okay - let me know if there's some other way to handle it.