Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing possible permissions error #300

Closed
wants to merge 5 commits into from
Closed

Conversation

loodvn
Copy link

@loodvn loodvn commented Aug 2, 2023

Fixes #299

@loodvn
Copy link
Author

loodvn commented Aug 2, 2023

Oops wait let me add a test first

@thomashopf
Copy link
Contributor

@loodvn I just had a look at the shutil docs:

dst must be the complete target file name; look at copy() for a copy that accepts a target directory path

Since fold_dir is a directory, I think copyfile is not applicable here unless one changes the destination handling

@loodvn
Copy link
Author

loodvn commented Jan 24, 2024

Ah yes thanks, I see in my original issue I had actually meant to change a different line (

copy(sequence_file, out_file)
).

But we've since figured out that these permissions errors are happening in many scripts on O2, so I don't think it's an EVcouplings issue, so happy to close the PR and associated issue.

Thanks for checking though!

@thomashopf
Copy link
Contributor

Thanks @loodvn! Will close this PR then.

@thomashopf thomashopf closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants