fix: success scenario number

deblockt · Mar 21, 2024 · 3cdb973 · 3cdb973
1 parent 16e284d
commit 3cdb973
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 10 deletions.
diff --git a/.github/workflows/test-jsond.yml b/.github/workflows/test-jsond.yml
@@ -15,7 +15,7 @@ jobs:
       - run: npm ci
       - run: npm run cucumber-message || true
       - uses: ./
-        name: "full report"
+        name: "JSOND - full report"
         with:
           name: "full report"
           access-token: ${{ secrets.GITHUB_TOKEN }}

diff --git a/dist/index.js b/dist/index.js
@@ -12268,10 +12268,9 @@ module.exports.reader = (reportString) => {
             }
         });
 
-    // TODO compute it reading file
     globalInfo.succeedScenarioNumber = Object.values(testCases)
         .filter(it => getTestCaseStatus(it) === 'success')
-        .reduce((a, b) => a + b, 0)
+        .length()
 
     return {
         get listAllScenarioByFile() {
@@ -12328,7 +12327,6 @@ module.exports.reader = (reportString) => {
 }
 
 function getTestCaseStatus(testCase) {
-    core.info(`testCase ${Object.keys(testCase)} ${testCase.steps}`)
     const steps = testCase.steps;
     for (const step of steps) {
         if (step.result.status === 'FAILED') {
@@ -12723,7 +12721,7 @@ function setOutput(core, outputName, summaryScenario, summarySteps) {
             },
           };
 
-        core.info('Creating summary: ' + summary);
+        core.info('Creating summary:\n' + summary);
         await core.summary
           .addHeading(checkName + additionnalTitleInfo, 4)
           .addRaw("\n" + summary)

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/index.js b/index.js
@@ -197,7 +197,7 @@ function setOutput(core, outputName, summaryScenario, summarySteps) {
             },
           };
 
-        core.info('Creating summary: ' + summary);
+        core.info('Creating summary:\n' + summary);
         await core.summary
           .addHeading(checkName + additionnalTitleInfo, 4)
           .addRaw("\n" + summary)

diff --git a/reportReader-jsond.js b/reportReader-jsond.js
@@ -103,10 +103,9 @@ module.exports.reader = (reportString) => {
             }
         });
 
-    // TODO compute it reading file
     globalInfo.succeedScenarioNumber = Object.values(testCases)
         .filter(it => getTestCaseStatus(it) === 'success')
-        .reduce((a, b) => a + b, 0)
+        .length()
 
     return {
         get listAllScenarioByFile() {
@@ -163,7 +162,6 @@ module.exports.reader = (reportString) => {
 }
 
 function getTestCaseStatus(testCase) {
-    core.info(`testCase ${Object.keys(testCase)} ${testCase.steps}`)
     const steps = testCase.steps;
     for (const step of steps) {
         if (step.result.status === 'FAILED') {