fix: bad output name

output name was set using full file path. Now only the report filename is used
deblockt · Apr 19, 2024 · 6752fe2 · 6752fe2
1 parent 269d53a
commit 6752fe2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -102,7 +102,7 @@ jobs:
           show-global-summary-report: 'true'
       - id: check-output
         name: "check output for cucumber-report-empty"
-        if: steps.success-with-empty-cucumber-report.output.cucumber-report-empty_failed_scenarios != 0
+        if: steps.success-with-empty-cucumber-report.outputs.cucumber-report-empty_failed_scenarios != 0
         run: exit 1
       - uses: ./
         id: job-failed

diff --git a/dist/index.js b/dist/index.js
@@ -12526,6 +12526,7 @@ const glob = __nccwpck_require__(8090);
 const fs = __nccwpck_require__(7147);
 const reportReaderJson = __nccwpck_require__(8797);
 const reportReaderNdJson = __nccwpck_require__(7069);
+const path = __nccwpck_require__(1017);
 
 function memoize(fn) {
     const cache = {};
@@ -12617,9 +12618,11 @@ function emojiByStatus(status) {
 
 function setOutput(core, outputName, summaryScenario, summarySteps) {
     for (const type in summaryScenario) {
+        core.debug(`publish output ${outputName}_${type}_scenarios=${summaryScenario[type]}`);
         core.setOutput(`${outputName}_${type}_scenarios`, summaryScenario[type]);
     }
     for (const type in summarySteps) {
+        core.debug(`publish output ${outputName}_${type}_steps=${summaryScenario[type]}`);
         core.setOutput(`${outputName}_${type}_steps`, summaryScenario[type]);
     }
 }
@@ -12646,7 +12649,7 @@ function setOutput(core, outputName, summaryScenario, summarySteps) {
     for await (const cucumberReportFile of globber.globGenerator()) {
         core.info("found cucumber report " + cucumberReportFile);
 
-        const reportOutputName = cucumberReportFile.replace(' ', '_').replace('.json', '');
+        const reportOutputName = path.basename(cucumberReportFile).replace(' ', '_').replace('.json', '');
         const reportResultString = await fs.promises.readFile(cucumberReportFile);
         const reportResult = (cucumberReportFile.endsWith('.json') ? reportReaderJson : reportReaderNdJson).reader(reportResultString);
         const globalInformation = reportResult.globalInformation;

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/index.js b/index.js
@@ -4,6 +4,7 @@ const glob = require("@actions/glob");
 const fs = require("fs");
 const reportReaderJson = require('./reportReader-json');
 const reportReaderNdJson = require('./reportReader-ndjson');
+const path = require('path');
 
 function memoize(fn) {
     const cache = {};
@@ -95,9 +96,11 @@ function emojiByStatus(status) {
 
 function setOutput(core, outputName, summaryScenario, summarySteps) {
     for (const type in summaryScenario) {
+        core.debug(`publish output ${outputName}_${type}_scenarios=${summaryScenario[type]}`);
         core.setOutput(`${outputName}_${type}_scenarios`, summaryScenario[type]);
     }
     for (const type in summarySteps) {
+        core.debug(`publish output ${outputName}_${type}_steps=${summaryScenario[type]}`);
         core.setOutput(`${outputName}_${type}_steps`, summaryScenario[type]);
     }
 }
@@ -124,7 +127,7 @@ function setOutput(core, outputName, summaryScenario, summarySteps) {
     for await (const cucumberReportFile of globber.globGenerator()) {
         core.info("found cucumber report " + cucumberReportFile);
 
-        const reportOutputName = cucumberReportFile.replace(' ', '_').replace('.json', '');
+        const reportOutputName = path.basename(cucumberReportFile).replace(' ', '_').replace('.json', '');
         const reportResultString = await fs.promises.readFile(cucumberReportFile);
         const reportResult = (cucumberReportFile.endsWith('.json') ? reportReaderJson : reportReaderNdJson).reader(reportResultString);
         const globalInformation = reportResult.globalInformation;