-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth command #253
Auth command #253
Conversation
41267c5
to
6252ecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestion after checking out the OAuth2 package docs 🙂
Use library functionality (and remove home-brewed alternatives) Co-authored-by: Linus Karlsson <[email protected]>
ecae1c0
to
4a66939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks excellent now! I hereby declare you an OAuth2 professional :).
6bcd988
to
7494f6c
Compare
CodeScene PR Check✅ Code Health Quality Gates: OK Change in average Code Health of affected files: +0.07 (9.62 -> 9.69)
View detailed results in CodeScene 🚩 Declining Code Health (highest to lowest):
|
Adds initial auth command with 3 subcommands:
In the future the other CLI commands which needs a token will use the saved credentials if a token is not specifically provided.
This is the initial version of the command, and there will be some changes to the backend before we can utilise it fully.