Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone shapes drop-down menu #220

Closed
wants to merge 1 commit into from
Closed

Conversation

IanMayo
Copy link
Member

@IanMayo IanMayo commented Feb 3, 2025

Fixes #211


For more details, open the Copilot Workspace session.

@Copilot Copilot bot review requested due to automatic review settings February 3, 2025 14:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/components/spatial/Zone/index.tsx:99

  • [nitpick] The variable name 'currentShape' is ambiguous. It should be renamed to 'currentDrawingShape' to make it clearer.
const [currentShape, setCurrentShape] = useState<LatLngExpression[]>([]);

src/components/Properties/index.tsx:14

  • Remove commented-out code to keep the codebase clean.
// useEffect(() => {

src/components/ControlPanel/index.tsx:162

  • The event parameter in handleMenuClick uses the 'any' type. Please use a more specific type such as 'MenuInfo' from 'antd'.
const handleMenuClick = (e: any) => {
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for reactol failed.

Name Link
🔨 Latest commit 898f548
🔍 Latest deploy log https://app.netlify.com/sites/reactol/deploys/67a0d503337efb0008af8629

@IanMayo
Copy link
Member Author

IanMayo commented Feb 3, 2025

Drop. Poor solution.

@IanMayo IanMayo closed this Feb 3, 2025
@IanMayo IanMayo deleted the IanMayo/add-zone-shapes branch February 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup menu for specifying type of zone
1 participant