Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure we handle empty values correctly #17

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Conversation

orlando
Copy link
Contributor

@orlando orlando commented Feb 19, 2021

What: fix: make sure we handle empty values correctly

Why: We are getting some errors on Discourse related to this. These are not currently being reported to Sentry, here's the github issue if someone wants to take a look debtcollective/discourse-sentry#3

How:

  • Update the code to handle empty values. We have this same code on the membership app, maybe there's an elegant way to extract this functionality.

Copy link
Contributor

@duranmla duranmla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way we are not gonna receive Sentry reports from any errors coming from this side, right?

@orlando
Copy link
Contributor Author

orlando commented Feb 20, 2021

Yeah, but the same errors we are getting here we're fixed on the membership app. We need to fix the sentry issue tho

@orlando orlando merged commit 957a31f into master Feb 22, 2021
@orlando orlando deleted the od/algolia-fix branch February 22, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants