Make puppeteer work in CI #15
Conversation
orlando
force-pushed
the
od/ci
branch
3 times, most recently
from
7183377 to
d60970c
Compare
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
========================================
+ Coverage 64.13% 80% +15.86%
========================================
Files 17 17
Lines 92 105 +13
Branches 3 4 +1
========================================
+ Hits 59 84 +25
+ Misses 30 18 -12
Partials 3 3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Some comments, nevertheless, I am also concern about the addition of puppeteer as a dependency. I am not certain if it actually makes any actual conflict with the serverless deployment for terms by any meaning.
Did you try to deploy?
Probably we skip the fact of adding the whole puppeteer for something although it may not affect at all because I can't find any note related to it in my journal (but I still have a small doubt about it)
| - libnss3 | ||
| sudo: required | ||
| node_js: | ||
| - "8" |
There was a problem hiding this comment.
Shall we care about the 8.16 vs 8 versions (we have 8.16 defined in our node-version and our service)
There was a problem hiding this comment.
I think we should test against the latest version in the 8 branch (currently is 8.16), this way we can know is safe to update when the release one.
There was a problem hiding this comment.
Right, so we should update this line in the CI to be 8.16? or not?
There was a problem hiding this comment.
no I think it's fine, this way we can test new versions of Node while having our build green. If something breaks we will know
|
@orlando few comments before approve. Take a look and let me know. |
|
@duranmla the puppeteer library is added as a The |
What: Make puppeteer work in CI
Why: Close #12, Close #23
How: