Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api key #12

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove api key #12

wants to merge 6 commits into from

Conversation

jyotiska
Copy link

Removed api key from the google_stt.py to prevent others from abusing the API_key.

@srizzling
Copy link
Contributor

It could be worth adding the API key to the config file :)

@brendanashworth
Copy link

It'd be nice if there was some sort of public key that we could use for the entire app, especially for people that don't have keys (like me). But, I think if its possible to abuse the key, good pr. 👍

@debugger22
Copy link
Owner

+1. You should also give a prompt if API key is not available and yeah a config file would be great.

@jyotiska
Copy link
Author

My suggestion is - do not expose your own API key to public. People should use their own API key if they want to use or build something with this app. I do not think google will let us use one universal public API key for this app. So, for now, let users use their own API key.

@debugger22
Copy link
Owner

That's what I'm saying. I just want that let users put API key in a config
file rather than the source code.

@srizzling
Copy link
Contributor

There is already a config fille which you can use. +1 for an exception if the user does not have an API key :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants