Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive speedup in analyze_macros #810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

Massive speedup in analyze_macros #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Massive speedup in analyze_macros 
Processing the same file went from 50s to 7s.
@Rafiot
Rafiot authored Mar 14, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 168a92d7c53d972f499356bda7d3335c61710eec
3 changes: 1 addition & 2 deletions oletools/olevba.py
View file
Original file line number Diff line number Diff line change
@@ -3636,8 +3636,7 @@ def analyze_macros(self, show_decoded_strings=False, deobfuscate=False):
# variable to merge source code from all modules:
if self.vba_code_all_modules is None:
self.vba_code_all_modules = self.get_vba_code_all_modules()
for (_, _, form_string) in self.extract_form_strings():
self.vba_code_all_modules += form_string + '\n'
self.vba_code_all_modules += '\n'.join(form_string for (_, _, form_string) in self.extract_form_strings())
# Analyze the whole code at once:
scanner = VBA_Scanner(self.vba_code_all_modules)
self.analysis_results = scanner.scan(show_decoded_strings, deobfuscate)