Fix default datetime widget format #7386
Open
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the issue described on #7319
Problem
When formatting dates, we currently use the format
'YYYY-MM-DDTHH:mm:ss.SSS[Z]'
by default. This format always includes a literal 'Z' timezone indicator (due to the escaped[Z]
) regardless of the user's actual timezone setting.This is a problem because:
utc
format see their local timezone in the widget but the data is actually stored in UTC (due to the forced 'Z' suffix)Solution
Modified the default date formatting to only append the escaped UTC indicator ('[Z]') when
picker_utc
is explicitly set totrue
. This ensures that:Technical Details
'YYYY-MM-DDTHH:mm:ss.SSS[Z]'
picker_utc: true
:'YYYY-MM-DDTHH:mm:ss.SSS[Z]'
picker_utc: false
:'YYYY-MM-DDTHH:mm:ss.SSSZ'
(preserves local timezone)Test plan
Added tests to check the date widget works as expected.
To run the tests:
Checklist
Please add a
x
inside each checkbox: