ADR-186: Place Identifiers #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d343946
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c00042f4.adr-cvq.pages.dev |
| Branch Preview URL: | https://adr-place-identifiers.adr-cvq.pages.dev |
menduz
reviewed
Feb 6, 2023
menduz
requested changes
Feb 6, 2023
Co-authored-by: menduz <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
menduz
approved these changes
Feb 6, 2023
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
Co-authored-by: Mariano Goldman <[email protected]> Signed-off-by: frami <[email protected]>
|
Just a quick question, the ADR defines the Places Identifiers, should we extend it a bit more to also include the full definition of a place? (the full data structure with name, creator, description, etc...) Or should we have this ADR just for the identifiers? |
aixaCode
approved these changes
Feb 7, 2023
marianogoldman
approved these changes
Feb 7, 2023
|
@davidejensen I would rather prefer to keep it simple and leave the definition of the data structure to its own ADR when we need it |
@2fd okay yes, sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: