fix: service falling down #499
Conversation
src/adapters/deployer/index.ts
Outdated
| if (!exists) { | ||
| await components.downloadQueue.onSizeLessThan(1000) | ||
| const isSnsEntityToSend = | ||
| !!(entity.entityType === 'scene' || entity.entityType === 'wearable' || entity.entityType === 'emote') && |
There was a problem hiding this comment.
| !!(entity.entityType === 'scene' || entity.entityType === 'wearable' || entity.entityType === 'emote') && | |
| (entity.entityType === 'scene' || entity.entityType === 'wearable' || entity.entityType === 'emote') && |
There was a problem hiding this comment.
components.sns.arn could be a string or undefined, so with !! we are foncing a boolean
myabe like this is getter
const isSnsEntityToSend = !!(
(entity.entityType === 'scene' || entity.entityType === 'wearable' || entity.entityType === 'emote') &&
components.sns.arn
)
There was a problem hiding this comment.
WDYT about using the !! just in the components.sns.arn?
| !!(entity.entityType === 'scene' || entity.entityType === 'wearable' || entity.entityType === 'emote') && | ||
| components.sns.arn | ||
| const isSnsEventToSend = !!components.sns.eventArn | ||
| if (exists || !(isSnsEntityToSend && isSnsEventToSend)) { |
There was a problem hiding this comment.
Do you think this could be easier to read?
| if (exists || !(isSnsEntityToSend && isSnsEventToSend)) { | |
| if (exists || !isSnsEntityToSend || !isSnsEventToSend) { |
There was a problem hiding this comment.
We need to specify that both isSnsEntityToSend and isSnsEventToSend are false
There was a problem hiding this comment.
Using !(isSnsEntityToSend && isSnsEventToSend), if any of isSnsEntityToSend or isSnsEventToSend are false, then !(isSnsEntityToSend && isSnsEventToSend) will be true. If both of them must be false then I think we should use ``(!isSnsEntityToSend && !isSnsEventToSend)`. WDYT?
No description provided.