fix: added disk cache versioning #3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DafGreco,
fcolarich and
mikhail-dcl
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
NickKhalow
approved these changes
Feb 26, 2025
| @@ -6,6 +6,9 @@ namespace ECS.StreamableLoading.Cache.Disk | |||
| { | |||
| public readonly struct CacheDirectory | |||
| { | |||
| //Bump this version if there is the need to wipe out the old disk cache when introducing major changes to DiskCaching | |||
| private const string CACHE_VERSION = "V1"; | |||
There was a problem hiding this comment.
can be int and "V" mode to DISK_CACHE_FOLDER name itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
This PR introduces Disk Cache versioning to allow full wipe of old cache when introducing major changes like partial loading and partial disk cache