fix: scene restriction error on shutdown #3454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed! Check the logs to see what went wrong |
github-actions
bot
requested review from
dalkia,
Ludmilafantaniella and
QThund
Ludmilafantaniella
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
🟢 I tested on both Windows and Mac, completed all the daily quests, and checked the logs for any errors related to SceneRestrictionBusController, NullReferenceException, ObjectDisposedException, or any unhandled exceptions during shutdown. No related issues were found.
Approved from QA 🚀
3454-evidence.mp4
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✔️ Log In/Log Out
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When the Explorer is shut down we have some exception being thrown. This PR addresses one of them regarding the scene restriction bus.
Addresses parts of #3428
What does this PR change?
Implements a dispose pattern on the
SceneRestrictionBusControllerin order to free its delegate preventing any unwanted invocation during the shutdown phase.Also adds a method to unsubscribe from the bus at will.
Test Instructions
While the S3 problem is present, these are the links for the builds:
Test Steps
Code Review Reference
Please review our Code Review Standards before submitting.