Skip to content

Commit

Permalink
Run commands using their real paths
Browse files Browse the repository at this point in the history
Fixes pypa#1164
  • Loading branch information
dechamps committed Dec 24, 2023
1 parent 1a3e6ad commit 881785f
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/pipx/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ def run_subprocess(
logger.info(f"running {log_cmd_str}")
# windows cannot take Path objects, only strings
cmd_str_list = [str(c) for c in cmd]
# Make sure to call the binary using its real path. This matters especially
# on Windows when using the packaged app (Microsoft Store) version of
# Python, which uses path redirection for sandboxing. If the path to the
# executable is redirected, the executable can get confused as to which
# directory it's being run from, leading to problems.
# See https://github.com/pypa/pipx/issues/1164
cmd_str_list[0] = os.path.realpath(cmd_str_list[0])
completed_process = subprocess.run(
cmd_str_list,
env=env,
Expand Down

0 comments on commit 881785f

Please sign in to comment.