-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to edit proposals after imports #234
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
…roposals-after-imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Anna,
Couple of things, you have chosen to modify the permissions class, another alternative might be to override the method def editable_by?(user)
in the model Proposal. This is a suggestion, in case it is easier.
Another thing that is needed, is the ability to scope the the feature to certain components, for this we need to add tests too, this is done with the constrains like in here
context "when constraints are present" do |
decidim-module-decidim_awesome/spec/forms/proposal_wizard_create_step_form_spec.rb
Line 110 in 05ab884
shared_examples "starts with caps" do |prop| |
In the admin, constrains are applied with the modal editor (needs to be added):
fixes #233