-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @vocdoni/sdk package from v0.0.16 to v0.4.0 #69
Conversation
a0223c1
to
a2d78d2
Compare
591efa7
to
bea6a4d
Compare
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 92.26% 92.14% -0.12%
==========================================
Files 87 87
Lines 1706 1706
==========================================
- Hits 1574 1572 -2
- Misses 132 134 +2
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
bb1f2b7
to
2dd8634
Compare
@@ -20,7 +20,6 @@ group :development, :test do | |||
end | |||
|
|||
group :development do | |||
gem "i18n-tasks", "~> 0.9.37" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@microstudi just to be sure, you're removing this as its not necessary, because its already a dependency of decidim-dev
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@microstudi about the NPM packages problems that we had, its already solved upstream, in I've tried it out locally and it seems to work well. The thing is that there's a failing spec, but I think its in vocdoni side, as I see some server/SDK errors in the CI output:
I guess they're related to the latest changes in their service:
So, @microstudi can you review this, merge and deploy to your server? I understand that merging a breaking CI its not kosher, but as currently we're using an ancient version (3 months and 9 versions ago), currently is broken too. At least by my local tries, I've seen that it works sometimes 😄 |
Vocdoni has mentioned thats because the v0.4.0 deploy isn't in staging yet, so I tried to v0.3.2 as that'd be more stable, but I still see that we have a failing spec... So as I say before, lets merge this and deploy it as its less broken than what we have now 🙈 |
@@ -20,7 +20,6 @@ group :development, :test do | |||
end | |||
|
|||
group :development do | |||
gem "i18n-tasks", "~> 0.9.37" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check the tests!
@microstudi last time I talked with the people from Vocdoni, they told me that the failing spec is related to how they handle their versions and APIs while they're on development. Basically, for now: v0.4.0 - works with the In a few days/weeks they'll migrate
As we don't have any current development in our side on the near future, I think it's better for now to just wait (3rd option) and this start blocking us then we can discuss the other options. For the moment I sent a rerun to see if the |
Currently the Vochain isn't compatible with v0.4.0, so we'll change our SDK configuration to development temporarily. Once v0.4.0 is compatible with staging we will turn back to that environment, as it's more stable than development.
Closing this as it was superseded by #72 |
I've also added a couple commands that are useful to regenerate and view the database, and an output for the SDK version in the JS console