-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal census system #71
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## node-backend #71 +/- ##
===============================================
Coverage ? 92.90%
===============================================
Files ? 94
Lines ? 1902
Branches ? 0
===============================================
Hits ? 1767
Misses ? 135
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, we are close to finish it.
I would like to suggest in this review some changes.
On one side, I would prefer to use more semantic name ins general (lets call internal_census instead of permissions for instance). I've left some examples in the comments.
I'd also improve a little the admin page, here is my suggestion:
Finally, I give you a suggestion to properly obtain valid users (from the organization, not deleted) with or without authorizations depending on the configurations.
app/commands/decidim/vocdoni/admin/create_census_with_permissions.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions for improving the feature. Can you check them out 🙏🏽 ?
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@andreslucena Andres, all the changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have more feedback, can you check it out?
db/migrate/20231107142971_add_census_data_to_decicid_vocdoni_elections.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the data selectors, I'm seeing that we have lots of them, so maybe we can move the task to an issue to not add too much workload on this PR.
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
@andreslucena all done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR as I'm happy with the result.
Thanks for your patience @antopalidi !! This looks great 👏🏽 👏🏽
fixes #60
add internal and external types for census
If the user is not logged in, a modal window appears when trying to start voting:
If the election is set up with an internal census and any type of verification is selected, a modal window with required missing verifications will be displayed when the user tries to start voting:
add "Update census" button to steps page, add info about the update