Feature: Bumps #56
Feature: Bumps #56
Conversation
|
Hi @holedaemon! Thanks so much for the PR. Sorry for only getting to it today, I've been busy with work. While I'm going through your code, could you walk me through how to use the feature and what the effects are when listening? I've yet to look deeper but I noticed mentions of a bump 'interval' and I'm not sure if that means normal playback is interrupted with bump tracks every X sec or something else. Don't mind the failing check for now - looks like a permission issue with pushing the built bot image to GHCR, but nothing related to your code itself. You're the first external contributor to Blanco so I'll have to fix perms 😃 Thanks! |
| con.commit() | ||
|
|
||
| try: | ||
| cur.execute(''' |
There was a problem hiding this comment.
This is more of a note to self, but in the future we might need to change how we handle column changes in existing schemas. The try-except pattern works well so far but I'm wary of it biting us in the future lol
There was a problem hiding this comment.
Totally agree. Out of curiosity, what was the reasoning behind the route taken for the database client, instead of an ORM or library?
There was a problem hiding this comment.
@holedaemon Haha, good question. I had some familiarity with SQLAlchemy from past projects that used MariaDB and Postgres, but I've never tried it with SQLite.
Blanco actually started out as a cog from an old general-purpose bot called Rico. While I was spinning Blanco off into a separate bot, I also had to decide on a way to persist state, and a full RDBMS seemed overkill so I decided on SQLite. I read somewhere that SQLite's weak typing and other quirks with ALTER statements could affect how ORMs interface with it so I just never bothered with one and wrote migrations by hand.
With 1.0.0 I might finally start using SQLAlchemy. Still think it's a little overkill for a tiny project, but if it helps maintainability then why not.
Howdy! No worries, sorry about the delay on my part. I've also been busy with work and some other projects. Sorry I didn't really provide any explanation as to how they work initially, I got a little bit ahead of myself. Bumps are off by default, and have to be toggled manually before use. The way the interval works is if N minutes have passed, then Blanco will play a bump after the current song ends, but before the next song starts -- there's no interruption. We've had bumps in rotation for a bit now and this has worked for us, but if you want that functionality to change at all, let me know. I'm going to start working on the requested changes, I'll keep you updated with anything I change. Appreciate your time! |
|
Thank you for the revisions, LGTM! |
Hello!
Here's that PR we discussed. My friends and I have tested for a few nights & everything seems to work pretty well. Let me know if there's anything you want me to change.
Thanks