Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rbac for webhooks #69

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix rbac for webhooks #69

merged 1 commit into from
Jan 20, 2025

Conversation

krpsh123
Copy link
Contributor

@krpsh123 krpsh123 commented Jan 20, 2025 •
edited
Loading

Description

Fixing RBAC for webhooks

Why do we need it, and what problem does it solve?

When creating an NFSStorageClass, the webhook fails with the error:

nfsstorageclasses.storage.deckhouse.io is forbidden: User "system:serviceaccount:d8-csi-nfs:webhooks" cannot list resource "nfsstorageclasses" in API group "storage.deckhouse.io" at the cluster scope

What is the expected result?

The error does not occur.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@krpsh123
[webhooks] fix rbac
fcde4f9 
Signed-off-by: Pavel Karpov <[email protected]>
@krpsh123 krpsh123 added the bug Something isn't working label Jan 20, 2025
@krpsh123 krpsh123 requested a review from AleksZimin January 20, 2025 12:02
@krpsh123 krpsh123 self-assigned this Jan 20, 2025
@krpsh123 krpsh123 marked this pull request as ready for review January 20, 2025 12:03
@AleksZimin AleksZimin merged commit 6d1e776 into main Jan 20, 2025
8 checks passed
@AleksZimin AleksZimin deleted the fix-rbac-webhooks branch January 20, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksZimin AleksZimin AleksZimin approved these changes

Assignees

@krpsh123 krpsh123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krpsh123 @AleksZimin