Skip to content

chore(hooks): impl generate secrets for dvcr hook in go #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Apr 29, 2025

Description

impl generate secrets for dvcr hook in go

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: chore
summary: impl generate secrets for dvcr hook in go
impact_level: low

Copy link
Contributor

@danilrwx danilrwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failed

Copy link
Member

@fl64 fl64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary that the old ones, which are created in the python hook, are also valid here

fl64

This comment was marked as duplicate.

fl64

This comment was marked as duplicate.

@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch 5 times, most recently from 615c9ba to 2e53f24 Compare April 30, 2025 11:55
@yaroslavborbat yaroslavborbat changed the title feat(hooks): impl generate secrets for dvcr hook in go chore(hooks): impl generate secrets for dvcr hook in go Apr 30, 2025
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch from 2e53f24 to 52c4e91 Compare April 30, 2025 14:35
@yaroslavborbat yaroslavborbat requested review from fl64 and danilrwx April 30, 2025 14:36
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch from 9bc1e02 to 051dc33 Compare April 30, 2025 16:57
danilrwx
danilrwx previously approved these changes May 7, 2025
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch 2 times, most recently from 9b7a4d1 to 2e79452 Compare May 7, 2025 10:30
@danilrwx danilrwx self-requested a review May 7, 2025 11:14
danilrwx
danilrwx previously approved these changes May 7, 2025
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch from 2e79452 to 4980e85 Compare May 12, 2025 09:25
@universal-itengineer universal-itengineer modified the milestones: v0.18.0, v0.19.0 May 12, 2025
fl64
fl64 previously approved these changes May 12, 2025
@yaroslavborbat yaroslavborbat dismissed stale reviews from fl64 and danilrwx via 5e83c67 May 14, 2025 08:40
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch from 4980e85 to 5e83c67 Compare May 14, 2025 08:40
diafour
diafour previously approved these changes May 14, 2025
diafour
diafour previously approved these changes May 14, 2025
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch 2 times, most recently from 1a57cb6 to 21372f1 Compare May 14, 2025 13:53
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the feat/impl-generate-sercrets-for-dvcr-in-go branch from 21372f1 to 07a1015 Compare May 15, 2025 07:45
@yaroslavborbat yaroslavborbat merged commit c0c39f2 into main May 15, 2025
22 of 23 checks passed
@yaroslavborbat yaroslavborbat deleted the feat/impl-generate-sercrets-for-dvcr-in-go branch May 15, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants