Skip to content

chore(vm): reduce noise in logs about "namespaces not found" #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(vm): reduce noise in logs about "namespaces not found" #1566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions images/virtualization-artifact/pkg/controller/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ handlersLoop:
case strings.Contains(err.Error(), "no new finalizers can be added if the object is being deleted"):
logger.FromContext(ctx).Warn("Forbidden to add finalizers", logger.SlogErr(err))
result.RequeueAfter = 1 * time.Second
case k8serrors.IsNotFound(err) && strings.Contains(err.Error(), "namespaces"):
// No need to return an explicit requeue or requeue with error if namespace is gone, e.g. in e2e tests.
logger.FromContext(ctx).Warn("Namespace is gone while reconcile the object", logger.SlogErr(err))
default:
logger.FromContext(ctx).Error("Failed to update resource", logger.SlogErr(err))
errs = errors.Join(errs, err)
Expand Down
Loading