Closes napalm-automation#2003: Fix NXOS ping source_interface bugs

decoupca · Sep 6, 2023 · 88d19dd · 88d19dd
1 parent 480cc91
commit 88d19dd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/napalm/nxos/nxos.py b/napalm/nxos/nxos.py
@@ -369,14 +369,14 @@ def ping(
         if source != "":
             command += " source {}".format(source)
         elif source_interface != "":
-            command += " source {}".format(source_interface)
+            command += " source-interface {}".format(source_interface)
 
         if vrf != "":
             command += " vrf {}".format(vrf)
         output = self._send_command(command, raw_text=True)
         assert isinstance(output, str)
 
-        if "connect:" in output:
+        if "connect:" in output.lower() or 'invalid' in output.lower():
             ping_dict["error"] = output
         elif "PING" in output:
             ping_dict["success"] = {