secp256k1/ecdsa: Remove some unnecessary subslices.

This updates the tests to avoid slicing things that are already a slice.
decred · Sep 21, 2023 · 813446b · 813446b
1 parent 87adb31
commit 813446b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/dcrec/secp256k1/ecdsa/signature_test.go b/dcrec/secp256k1/ecdsa/signature_test.go
@@ -639,7 +639,7 @@ func TestSignAndVerifyRandom(t *testing.T) {
 		randByte = rng.Intn(len(badHash))
 		randBit = rng.Intn(7)
 		badHash[randByte] ^= 1 << randBit
-		if sig.Verify(badHash[:], pubKey) {
+		if sig.Verify(badHash, pubKey) {
 			t.Fatalf("verified signature for bad hash\nsig: %x\nhash: %x\n"+
 				"pubkey: %x", sig.Serialize(), badHash,
 				pubKey.SerializeCompressed())
@@ -676,7 +676,7 @@ func TestSignFailures(t *testing.T) {
 		nonce := hexToModNScalar(test.nonce)
 
 		// Ensure the signing is NOT successful.
-		sig, _, success := sign(privKey, nonce, hash[:])
+		sig, _, success := sign(privKey, nonce, hash)
 		if success {
 			t.Errorf("%s: unexpected success -- got sig %x", test.name,
 				sig.Serialize())
@@ -1061,7 +1061,7 @@ func TestSignAndRecoverCompactRandom(t *testing.T) {
 			randByte = rng.Intn(len(badHash))
 			randBit = rng.Intn(7)
 			badHash[randByte] ^= 1 << randBit
-			badPubKey, _, err = RecoverCompact(gotSig, badHash[:])
+			badPubKey, _, err = RecoverCompact(gotSig, badHash)
 			if err == nil && badPubKey.IsEqual(wantPubKey) {
 				t.Fatalf("recovered public key for bad hash: %x\nsig: %x\n"+
 					"private key: %x", badHash, gotSig, privKey.Serialize())