server: Don't wait or try to send notfound data. #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Oct 31, 2023
davecgh
force-pushed
the
server_no_wait_on_notfound_data
branch
from
963a341 to
d582422
Compare
This modifies the recent concurrent getdata serving logic to immediately decrement the pending item count and move on to the next requested data item when an item is not found. Not only is it more efficient since it means there is no attempt to acquire the semaphore, it also prevents an issue the new code introduced where it could incorrectly queue up a nil message leading to a panic.
davecgh
force-pushed
the
server_no_wait_on_notfound_data
branch
from
d582422 to
c1e4cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the recent concurrent
getdataserving logic to immediately decrement the pending item count and move on to the next requested data item when an item is not found.Not only is it more efficient since it means there is no attempt to acquire the semaphore, it also prevents an issue the new code introduced where it could incorrectly queue up a nil message leading to a panic.