run_tests.sh: allow passing of additional test arguments #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 39e2cc2 a TestMain was added that parsed all of the arguments passed to the dcrd.test executable, allowing any additional arguments not parsed by the test binary to be used by dcrd code. This change modifies the run_tests.sh script to allow passing of additional arguments as well, which allows doing: ./run_tests.sh -- --appdata=$(mktemp -d) This allows the config tests to pass even when run under a sandboxed environment without a home directory, or where the home directory is read-only.
davecgh
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 39e2cc2 a TestMain was added that parsed all of the arguments passed to the dcrd.test executable, allowing any additional arguments not parsed by the test binary to be used by dcrd code. This change modifies the run_tests.sh script to allow passing of additional arguments as well, which allows doing:
./run_tests.sh -- --appdata=$(mktemp -d)
This allows the config tests to pass even when run under a sandboxed environment without a home directory, or where the home directory is read-only.