mixclient: Sort roots for slot assignment #3453
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of the SR (slot reservation) mix is to determine unique anonymous slot positions for the DC-net (xor) mix. However, there was a missing check by non-root-solving peers that the published roots are in the proper order. This could result in a malicious actor publishing roots in a different order, disrupting mixes by causing non-root-solving peers to unknowingly perform the DC-net in the wrong slots, and causing the wrong peers to be blamed for disrupting the mix. Prevent this by requiring roots to be sorted before slots are discovered. This also matches the root-sorting that occurred in the older client-server design. This change is not compatible with previous mixclient versions, as the DC-net mix would occur with peers writing messages into different slots. The pairing version included in PR messages is updated to reflect this.
davecgh
approved these changes
Nov 11, 2024
davecgh
added
the
mix pairing version change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the SR (slot reservation) mix is to determine unique anonymous slot positions for the DC-net (xor) mix. However, there was a missing check by non-root-solving peers that the published roots are in the proper order. This could result in a malicious actor publishing roots in a different order, disrupting mixes by causing non-root-solving peers to unknowingly perform the DC-net in the wrong slots, and causing the wrong peers to be blamed for disrupting the mix.
Prevent this by requiring roots to be sorted before slots are discovered. This also matches the root-sorting that occurred in the older client-server design.
This change is not compatible with previous mixclient versions, as the DC-net mix would occur with peers writing messages into different slots. The pairing version included in PR messages is updated to reflect this.