mixpool: Do not return early for revealed secrets #3454
Merged
+28
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a RS (reveal secrets) message was published, the mixpool Receive method would immediately return, and blame assignment was immediately run. This created a logic race (due to message propagation over the network) where not all peers would run blame assignment with all currently-published messages, and different peers would blame different sets of peers for missing messages. Correct this by modifying the Receive method to not return ErrSecretsRevealed until the total number of expected messages have been received first.
davecgh
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a RS (reveal secrets) message was published, the mixpool Receive method would immediately return, and blame assignment was immediately run. This created a logic race (due to message propagation over the network) where not all peers would run blame assignment with all currently-published messages, and different peers would blame different sets of peers for missing messages.
Correct this by modifying the Receive method to not return ErrSecretsRevealed until the total number of expected messages have been received first.