client/core: allow maker match status MatchConfirmed when redeem can't be reported #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
makerghost-fixes
branch
from
ab3527e to
202b1cd
Compare
ukane-philemon
approved these changes
Sep 8, 2023
martonp
approved these changes
Sep 9, 2023
|
closes #2465 ? |
JoeGruffins
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to do this in order for the simnet-trade-tests
makerghosttest to pass, e.g../run dcrbtrc -t makerghost.When we, for the purposes of testing, intentionally block the maker from sending their
redeem\o the server, the maker is stuck in the statusMakerSwapCast. The server will eventually revoke the match, and the maker seems to be stuck inMakerSwapCastindefinitely, never satisfying the test, but more importantly blocking the order from being retired.In practice, this would be like the maker losing contact with the server before redeeming and not establishing contact again until after the server revokes the match. So unless I'm missing something, this scenario is possible, could be caused by user intervention, and we're just not handling it.
closes #2465