client/{core,mm}: Rebalance on EpochMatchSummary instead of new epoch #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the basic market maker to rebalance when the order book receives an EpochMatchSummary notification from the server instead of when an `EpochNotification` arrives. When the `EpochNotification` arrives, the orderbook has not yet been updated with the matches of the previous epoch.
martonp
force-pushed
the
rebalanceOnMatchReport
branch
from
0f5923d to
b8fbf97
Compare
buck54321
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the basic market maker to rebalance when the order book receives an
EpochMatchSummarynotification from the server instead of when anEpochNotificationarrives. When theEpochNotificationarrives, the OrderBook has not yet been updated with the matches of the previous epoch.