add zclassic #2523
Merged
add zclassic #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the right coin? https://zclassic.org/ I clicked on |
Correct website, that link was wrong. It should be fixed now, thank you! |
JoeGruffins
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Can you chmod +x the harness.sh
I see in the alpha node a lot:
CreateNewBlock(): total size 1000
ERROR: CheckProofOfWork(): hash doesn't match nBits
ERROR: CheckProofOfWork(): hash doesn't match nBits
ERROR: CheckProofOfWork(): hash doesn't match nBits
ERROR: CheckProofOfWork(): hash doesn't match nBits
Can you add zcl to client's simnet-setup.sh.
| Description: "This is the highest network fee rate you are willing to " + | ||
| "pay on swap transactions. If feeratelimit is lower than a market's " + | ||
| "maxfeerate, you will not be able to trade on that market with this " + | ||
| "wallet. Units: BTC/kB", |
There was a problem hiding this comment.
units ZCL/kb maybe?
There's a lot of comments with zcash/zec as well. I'll just comment here once. It's no big deal.
buck54321
force-pushed
the
zcl
branch
2 times, most recently
from
66be537 to
c369f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward, except for the new sighash function that was needed for version 4 transactions. Other than that, everything should be pretty familiar from adding other assets.
ShieldedWalletyet. Will follow up with that, but zcl doesn't have the issues that Zcash has with their API, so that helps.