-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Custom VSP URL in VSP selection dialog #2529
Conversation
1cbc857
to
d2ed286
Compare
</table>{{/* TODO: ADD MANUAL INPUT */}} | ||
</table> | ||
<p class="mt-3"> | ||
<label for="customVspUrl">Or add custom VSP URL:</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs translation. Add an entry for this in en-us.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like just the staking related strings are not localized. I think if you wanted to do them here I think it would be fine, or it could be done in another issue as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in #2544
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, every displayed string would have a translation entry, even if just en-US. But I'm as much if not more guilty than others of not doing it, so I understand and I tend to be permissive. @peterzen, I won't hold this up, but in general try to do translation and definitely do them if someone calls them out in review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - in this one I did the l18n separately so as not to clutter the PR with changes that are unrelated to the feature.
41ca07a
to
17cf009
Compare
@peterzen it does not seem github recognizes "Solves" can you change it to something that closes the issue automatically? I know "closes" does... Any of these https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword |
Sorry about that, updated. |
17cf009
to
ff91211
Compare
ff91211
to
0d77340
Compare
This PR adds the ability to enter an arbitrary VSP URL.
Closes #2498