Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Custom VSP URL in VSP selection dialog #2529

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

peterzen
Copy link
Member

@peterzen peterzen commented Sep 17, 2023

This PR adds the ability to enter an arbitrary VSP URL.

Closes #2498

@peterzen peterzen changed the title Custom VSP URL in VSP selection dialog ui: Custom VSP URL in VSP selection dialog Sep 17, 2023
client/webserver/site/src/js/wallets.ts Outdated Show resolved Hide resolved
</table>{{/* TODO: ADD MANUAL INPUT */}}
</table>
<p class="mt-3">
<label for="customVspUrl">Or add custom VSP URL:</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs translation. Add an entry for this in en-us.go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the strings in wallets.tmpl are not localized yet. Maybe it's best to have a separate issue to cover all of those? (Probably related to/overlaps with #1454, #1880?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like just the staking related strings are not localized. I think if you wanted to do them here I think it would be fine, or it could be done in another issue as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #2544

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, every displayed string would have a translation entry, even if just en-US. But I'm as much if not more guilty than others of not doing it, so I understand and I tend to be permissive. @peterzen, I won't hold this up, but in general try to do translation and definitely do them if someone calls them out in review.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - in this one I did the l18n separately so as not to clutter the PR with changes that are unrelated to the feature.

@peterzen peterzen force-pushed the add-custom-vsp-ui branch 2 times, most recently from 41ca07a to 17cf009 Compare September 18, 2023 09:27
@JoeGruffins
Copy link
Member

@peterzen it does not seem github recognizes "Solves" can you change it to something that closes the issue automatically? I know "closes" does... Any of these https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@peterzen
Copy link
Member Author

@peterzen it does not seem github recognizes "Solves" can you change it to something that closes the issue automatically? I know "closes" does... Any of these https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Sorry about that, updated.

@buck54321 buck54321 merged commit 944ca61 into decred:master Sep 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: need an input for a custom vsp
4 participants