client/comms,binance: Update ws connection URL #3016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the ws connection interface to allow for updating of the URL. This is useful for the connection to Binance. If additional markets are subscribed after the initial connection to the market streams API, in the event of an error, the websocket connection will reconnect using the initial URL, and the additional markets will only be resubscribed after a list subscriptions check is done. With this change, all the markets will be subscribed during a reconnection.
|
Just saw #3015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ws connection interface to allow for updating of the URL. This is useful for the connection to Binance. If additional markets are subscribed after the initial connection to the market streams API, in the event of an error, the websocket connection will reconnect using the initial URL, and the additional markets will only be resubscribed after a list subscriptions check is done. With this change, all the markets will be subscribed during a reconnection.