Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-cn.go #3098

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update zh-cn.go #3098

wants to merge 2 commits into from

Conversation

decredclub
Copy link

I translated it into Chinese based on the English configuration file and have proofread it;

I translated it into Chinese based on the English configuration file and have proofread it;
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't read but google translated a few and looks good. Needs one change to build.

$ go build
# decred.org/dcrdex/client/webserver/locales
../../webserver/locales/zh-cn.go:599:54: invalid field name "Notes" in struct literal

client/webserver/locales/zh-cn.go Outdated Show resolved Hide resolved
@decredclub
Copy link
Author

decredclub commented Nov 27, 2024

What else do I need to do?I’m glad to see that the Chinese community can also use dcrdex!

@dev-warrior777
Copy link
Contributor

What else do I need to do?I’m glad to see that the Chinese community can also use dcrdex!

There are these New required translations: #3071 (comment)

@dev-warrior777
Copy link
Contributor

What else do I need to do?I’m glad to see that the Chinese community can also use dcrdex!

There are these New required translations: #3071 (comment)

  • The translations in "jsintl.go" on this PR Update zh-cn.go need to be compared with the translations in #3071 also in jsintl.go which may be different

  • There is also this conflict where I have translated for Version in client/webserver/locales/zh-cn.go in PR #3096 so please do not touch that one liner:

image

It is now supposed to mean Version and not Build ID

@dev-warrior777
Copy link
Contributor

Let us continue the conversation on #3071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants