spv: Refactor initial cfilter fetching to be done in smaller batches #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits cfilter fetching during initial sync to use smaller sized batches of requests. This makes the code ready to switch to batched cfilter fetching on a per-peer basis when a new protocol version is introduced that supports it.
This refactors the CFiltersV2 function to reduce the number of goroutines used, therefore slightly reducing total cpu and memory load and making it easier to run the race detector and debug issues. The number of goroutines is reduced from one per block hash in the request to two per call. This is done by refactoring the code to use one goroutine to send all requests and one to read the responses, while ensuring that the requests are still sent as fast as the network stack will allow it.
jrick
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the initial cfilter fetching to be based around requesting smaller batches of cfilters from the lower p2p level.
While this does not make any functional difference at the moment, in the future, when a P2P protocol with batched CFilter is supported (decred/dcrd#3211 or equivalent), it will be trivial to switch to using it for remote peers that support it.
Additionally, this reduces the total number of goroutines used for the underlying
CFiltersV2()call from the p2p package, which is useful in slightly reducing the total cpu and memory loads during initial sync.